Re: [PATCH v2] PCI: starfive: Fix unchecked pm_runtime_get_sync() in probe

Manivannan Sadhasivam <[email protected]>
Newsgroups org.kernel.vger.linux-pci,org.kernel.vger.linux-kernel
Message-ID <178534341803.895624.4395284068749198386.b4-ty@b4>
On Sat, 18 Jul 2026 20:33:51 +0500, Ali Tariq wrote:
> pm_runtime_get_sync() is called in starfive_pcie_probe() without
> checking its return value. If runtime resume fails, the driver
> proceeds to configure PCIe hardware through regmap_update_bits(),
> enable clocks and resets, and power on the PHY, even though the
> device may not actually be powered.
> 
> pm_runtime_get_sync() also increments the usage counter even when
> resume fails, which would leave the counter unbalanced if this
> error path were later handled without additional cleanup.
> 
> [...]

Applied, thanks!

[1/1] PCI: starfive: Fix unchecked pm_runtime_get_sync() in probe
      commit: aaae917990623a6ca6b638557056606a1ae4a8d6

Best regards,
-- 
மணிவண்ணன் சதாசிவம்
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.