Re: [PATCH v7 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect GPIO polarity for w-disable2-gpios inverts M.2 Bluetooth radio disable logic.
--

--- Patch [2]: [PATCH v7 2/3] arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector ---
commit 1b7021041bf505a0f78e56766606ecebc1d465b4
Author: Krishna Chaitanya Chundru <[email protected]>

arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector

This commit enables the PCIe0 root port and its QMP PHY for the Eliza EVK
board's M.2 E key connector. It provisions a 3.3V regulator supply via an
I2C GPIO expander and defines the connector to host a WLAN card over PCIe
and a Bluetooth device over UART.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> index e47b24f8b8277..b35fffb509765 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi

[ ... ]

> +	connector-0 {
> +		compatible = "pcie-m2-e-connector";
> +		vpcie3v3-supply = <&vreg_pcie_m_3p3>;
> +		w-disable1-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> +		w-disable2-gpios = <&pm8550vs_g_gpios 4 GPIO_ACTIVE_HIGH>;

[Severity: Medium]
Does this GPIO polarity correctly model the M.2 specification? The M.2 standard
defines W_DISABLE2# as an active-low signal, meaning a physical LOW disables
the radio. 

If the pwrseq-pcie-m2 driver expects an active-low signal and de-asserts
the GPIO to enable the radio, specifying GPIO_ACTIVE_HIGH here will cause
the physical pin to be driven LOW instead, inadvertently holding the
Bluetooth radio in a disabled state.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2