Re: [PATCH 13/13] PCI: Add KUnit coverage for ACS isolation checks

[email protected] Sun, 02 Aug 2026 16:07:13 +0000
Newsgroups org.kernel.vger.linux-pci
Message-ID <[email protected]>
> From: Leon Romanovsky <[email protected]>
> 
> Direct Translated P2P and Egress Control both let a peer request reach
> the peer without Request Redirect, and whether Request Redirect still
> isolates depends further on Translation Blocking and on the flags the
> caller requests. Firmware owns these bits, so the combinations are not
> reachable on a given machine.
> 
> Drive pci_acs_flags_enabled() with a fake pci_ops supplying the ACS
> Control register and check each combination. The function is exposed
> under CONFIG_KUNIT via VISIBLE_IF_KUNIT.
> 
> Signed-off-by: Leon Romanovsky <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=13