Re: [PATCH v9 2/3] PCI: Add missing headers transitively included by <linux/phy/phy.h>
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> The tegra as well as a few dwc PCI controller drivers uses PM runtime > operations without including the required <linux/pm_runtime.h> header. > > Similarly, pcie-rockchip-host, pcie-starfive as well as a few dwc PCI > controllers use the regulator consumer API without including > <linux/regulator/consumer.h>. > > pcie-spacemit-k1.c uses of_get_next_available_child() and of_node_put() > without including <linux/of.h>. > > It seems these function prototypes were indirectly provided by > <linux/phy/phy.h>, mostly by mistake (none of the functions it exports > need it). > > Before the PHY header can drop the unnecessary includes, make sure the > PCI controller drivers include what they use. > > Signed-off-by: Vladimir Oltean <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2