Re: [PATCH v3 3/3] PCI: rzg3s: Fix IRQ domain initialization error handling
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> From: Lad Prabhakar <[email protected]> > > rzg3s_pcie_init_irqdomain() installs chained handlers for the INTx > parent interrupts before creating the INTx irqdomain and initializing > MSI support. > > If any subsequent step fails, such as obtaining an INTx IRQ, > creating the irqdomain, or initializing MSI, the error path returns > without removing any chained handlers that were already installed. > This leaves stale handler and data pointers attached to the parent > interrupts. > > Add a helper to tear down the INTx IRQ setup, including removing the IRQ > domain and clearing the chained handlers. Use it to unwind partially > completed initialization and from the normal IRQ domain teardown path. > > Fixes: 7ef502fb35b28 ("PCI: Add Renesas RZ/G3S host controller driver") > Cc: [email protected] > Signed-off-by: Lad Prabhakar <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3