Re: [PATCH v6 3/5] nfs: introduce nfs_release_request_list helper
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> Introduce a centralized helper, nfs_release_request_list, to handle > the bulk release of nfs_page requests from a list. > > This serves as a preparatory step for two upcoming improvements: > > 1. Pin-Aware Cleanup: As we migrate to iov_iter_extract_* API, > requests will hold pins (GUP) instead of standard references. The > helper ensures that the correct unpinning logic gets applied > consistently across all requests in a list. > > 2. Folio Support: In subsequent patches where nfs_page structures > will cover multi-page folios, this helper provides a clean > infrastructure to unlock these larger units of I/O in bulk during > completion, similar to the pattern in bio_release_pages. > > Additionally, refactor nfs_read_sync_pgio_error() to utilize this new > helper. > > Signed-off-by: Pranjal Shrivastava <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3