Re: [PATCH V3 2/5] PCI: Move __pcie_update_link_speed() out of line
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> __pcie_update_link_speed() records the current speed and Flit Mode state > of a bus and emits the link event trace point. It is a static inline in > drivers/pci/pci.h, but it has only two callers, pcie_update_link_speed() > in drivers/pci/probe.c and pciehp_check_link_status(), and it is never on > a hot path, so inlining buys nothing. > > A subsequent change makes it re-evaluate the Device 3 Control register of > the bridge, which is more of the PCI core than belongs in a header. Move > the body to drivers/pci/probe.c and leave only a declaration behind. > > No functional change intended. > > Signed-off-by: Vidya Sagar <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2