Re: [PATCH] PCI: qcom: Add register dump support for PCIe Link Down events
Konrad Dybcio <[email protected]>
| Newsgroups | org.kernel.vger.linux-pci,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/11/26 6:12 PM, Krishna Chaitanya Chundru wrote: > When the PCIe link goes down unexpectedly, being able to inspect the > state of key controller registers at the time of failure is valuable > for root-causing the issue. In this current form, does this patch not cause the splats to appear for non-fatal linkdowns (e.g. hot-unplug)? > If a storage endpoint is present downstream, the dump is printed > directly via dev_err() so it is visible in dmesg immediately, since a > devcoredump read from userspace could otherwise race with a storage > failure. Otherwise, the buffer is handed to the devcoredump framework > so it can be collected from /sys/class/devcoredump/ for offline > analysis. I think this is a bit too much, a single implementation is enough. Konrad