Re: [PATCH v5 7/7] PCI/MSI: re-enable conditional parent mask/unmask with sw moderation
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> Recent commits removed masking of interrupts at the PCIe level when > the masking is also done at the parent (e.g. on ARM with GIC). This > optimization saves the PCIe write, and especially the expensive readback, > but causes the device to still send MSI interrupts that are ignored. > > As a result, it very harmful on platforms (many, for multiple > architectures) that are unable to deal with too many MSI interrupts, and > defeats GSIM (CONFIG_IRQ_SW_MODERATION), which is esplicitely designed to > address this problem, but depends on masking interrupts at the PCIe level. > > Revert to the old behavior when GSIM (CONFIG_IRQ_SW_MODERATION) > is compiled in. > > Signed-off-by: Luigi Rizzo <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7