Re: [PATCH v3 1/2] PCI: dwc: Add .post_deinit counterpart to endpoint .pre_init callback
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> If .pre_init() succeeds but subsequent initialization fails, it is > mandatory to correctly undo the hardware configuration which the > .pre_init() callback did. Intrododuce .post_deinit() callback to do > exactly that, undo what the .pre_init() callback did. Usually, that > means stop the clock, assert reset, and possibly program some registers > to quiescense the hardware. Invoke the .post_deinit() callback in > dw_pcie_ep_deinit() to retain functional symmetry. > > Reviewed-by: Koichiro Den <[email protected]> > Tested-by: Koichiro Den <[email protected]> > Signed-off-by: Marek Vasut <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1