Re: [PATCH v4 06/18] PCI/P2PDMA: Gate the host bridge whitelist warning on verbose
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> From: Leon Romanovsky <[email protected]> > > calc_map_type_and_dist() prints every other diagnostic under its verbose > argument, but reaches the "Host bridge not in P2PDMA whitelist" warning > through host_bridge_whitelist(), which it hands acs_redirects instead. > A caller that asked for a silent answer still gets the warning whenever > any port on the path has an ACS redirect bit set, the CPU is not > whitelisted by cpu_supports_p2pdma(), and the host bridge is not in > pci_p2pdma_whitelist[]. > > pci_p2pmem_find_many() is such a caller. It sweeps every device with > published p2pmem and asks for the distance to each client with > verbose=false, and pci_p2pdma_distance_many() recomputes rather than > consulting the map_types cache, so the warning repeats on every sweep. > > [ ... ] > which vendor and device would have to be added to the whitelist. > > Tested-by: Tushar Dave <[email protected]> > Fixes: d1b8dc09dd71 ("PCI/P2PDMA: Simplify distance calculation") > Signed-off-by: Leon Romanovsky <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6