Re: [PATCH v4 14/18] PCI/P2PDMA: Extract pure ACS routing decision helpers
| Newsgroups | org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
> From: Leon Romanovsky <[email protected]> > > The ACS routing decision and Egress Control Vector size calculation are > mixed with config-space I/O, which makes their branch-heavy behavior > difficult to exercise independently. > > Extract pci_acs_p2pdma_decision() with explicit Request or Completion type, > target availability, and vector state inputs. Extract > pci_acs_egress_port_valid() for the encoded vector-size boundary. Keep > config access in their callers and expose only the pure helpers under > CONFIG_KUNIT. > > Tested-by: Tushar Dave <[email protected]> > Signed-off-by: Leon Romanovsky <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=14