Re: [PATCH v3 0/3] perf tools: Fix memory issues
Namhyung Kim <[email protected]> Wed, 5 Aug 2026 22:12:33 -0700
| Newsgroups | org.kernel.vger.linux-perf-users,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello, On Mon, Aug 03, 2026 at 03:51:51PM +0200, Michalis Niarchos via B4 Relay wrote: > Running: > $ perf kvm stat record -a sleep 10 > > gives this output: > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 1.361 MB perf.data.guest ] > double free or corruption (!prev) > > In the process of resolving this, I came across some memory leaks. I think those issues are already fixed in the perf-tools-next. Can you please check the latest code? Thanks, Namhyung > > Signed-off-by: Michalis Niarchos <[email protected]> > --- > Changes in v3: > - Moved dead code removal to the correct patch. > - Squashed double free patches, as both fix the same rec_argv > double-free/leak pattern. > - Link to v2: https://patch.msgid.link/[email protected] > > Changes in v2: > - Removed code block that was rendered dead by the > get_filename_for_perf_kvm() change. > - Dropped invalid free() fix from kvm_events_report(). > - Added double free fixes for: __cmd_record(), __cmd_report(), > __cmd_buildid_list(), and __cmd_top(), which follow the same pattern > as kvm_events_record(). > - Link to v1: https://patch.msgid.link/[email protected] > > To: Peter Zijlstra <[email protected]> > To: Ingo Molnar <[email protected]> > To: Arnaldo Carvalho de Melo <[email protected]> > To: Namhyung Kim <[email protected]> > To: Mark Rutland <[email protected]> > To: Alexander Shishkin <[email protected]> > To: Jiri Olsa <[email protected]> > To: Ian Rogers <[email protected]> > To: Adrian Hunter <[email protected]> > To: James Clark <[email protected]> > Cc: [email protected] > Cc: [email protected] > > --- > Michalis Niarchos (3): > perf tools: Fix memory leak in cmd_kvm() > perf tools: Fix double free and memory leak issues > perf tools: Fix memory leak in cmd_kvm() > > tools/perf/builtin-kvm.c | 99 +++++++++++------------- > tools/perf/util/kvm-stat-arch/kvm-stat-powerpc.c | 4 +- > tools/perf/util/kvm-stat-arch/kvm-stat-x86.c | 10 +-- > 3 files changed, 50 insertions(+), 63 deletions(-) > --- > base-commit: a1ed064cb4db70af8c4177b3805ca5b8b0be567e > change-id: 20260731-perf-kvm-fixes-a17f0aa048ad > > Best regards, > -- > Michalis Niarchos <[email protected]> > >