Re: [PATCH v7 2/9] perf c2c: add function view browser skeleton

Jiebin Sun <[email protected]>
Newsgroups org.kernel.vger.linux-perf-users,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi Namhyung,

> I don't think it's a proper fix.  The c2c-function.o should belong to
> libperf-ui.a.  Perhabs we can split libperf-tui.a and not link it to the
> python module.  But still, it's better to move the common code into the
> util directory.

Thanks. I reworked this in v8 to keep c2c-function.o in libperf-ui.a and
removed the v7 tools/perf/Build change.

builtin-c2c.c now passes the cacheline histograms, the --coalesce field
list, symbol_full, and the cacheline detail callback through
struct c2c_function_view_args. The browser no longer references the
command-private c2c instance or perf_c2c__browse_cacheline().

The shared c2c types and formatter callbacks are now in util/c2c.h and
util/c2c.c. struct perf_c2c and the command state remain private to
builtin-c2c.c.

Thanks,
Jiebin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.