Re: [PATCH 6/7] perf build: Remove leftover feature tests for removed cxx and clang support

On Sun, Aug 9, 2026 at 5:52 PM Arnaldo Carvalho de Melo <[email protected]> wrote:
>
> From: Arnaldo Carvalho de Melo <[email protected]>
>
> 56b11a2126bf2f42 ("perf bpf: Remove support for embedding clang for
> compiling BPF events (-e foo.c)") removed the test-cxx.cpp and
> test-clang.cpp sources, but left behind their entries in the feature
> test FILES list, the build rules and the cxx and clang entries in
> FEATURE_TESTS_EXTRA.
>
> Since the sources no longer exist, those rules would always fail,
> making the artificial feature-cxx and feature-clang results to be
> perpetually disabled/absent, remove the leftover entries, making the
> feature test scripts list match the available sources.
>
> Assisted-by: opencode:deepseek-v4-flash-free
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

Looks good, perhaps a Fixes tag given the commit above?

Thanks,
Ian

> ---
>  tools/build/Makefile.feature |  2 --
>  tools/build/feature/Makefile | 14 --------------
>  2 files changed, 16 deletions(-)
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index ed1374af31c16838..99eb0ea095375606 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -123,9 +123,7 @@ FEATURE_TESTS_EXTRA :=                  \
>           libbfd-liberty-z               \
>           libopencsd                     \
>           libperl                        \
> -         cxx                            \
>           llvm                           \
> -         clang                          \
>           libbpf                         \
>           libpfm4                        \
>           libdebuginfod                 \
> diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
> index 62909a9c799d3338..7d165018116a552f 100644
> --- a/tools/build/feature/Makefile
> +++ b/tools/build/feature/Makefile
> @@ -55,7 +55,6 @@ FILES=                                          \
>           test-bpf.bin                           \
>           test-libbpf.bin                        \
>           test-sdt.bin                           \
> -         test-cxx.bin                           \
>           test-gettid.bin                       \
>           test-jvmti.bin                                \
>           test-jvmti-cmlr.bin                   \
> @@ -63,7 +62,6 @@ FILES=                                          \
>           test-sched_getcpu.bin                 \
>           test-setns.bin                                \
>           test-libopencsd.bin                   \
> -         test-clang.bin                                \
>           test-llvm.bin                         \
>           test-llvm-perf.bin                    \
>           test-libaio.bin                       \
> @@ -335,9 +333,6 @@ $(OUTPUT)test-libbpf.bin:
>  $(OUTPUT)test-sdt.bin:
>         $(BUILD)
>
> -$(OUTPUT)test-cxx.bin:
> -       $(BUILDXX) -std=gnu++11
> -
>  $(OUTPUT)test-gettid.bin:
>         $(BUILD)
>
> @@ -363,15 +358,6 @@ $(OUTPUT)test-llvm-perf.bin:
>                 $(shell $(LLVM_CONFIG) --system-libs)           \
>                 > $(@:.bin=.make.output) 2>&1
>
> -$(OUTPUT)test-clang.bin:
> -       $(BUILDXX) -std=gnu++17                                 \
> -               -I$(shell $(LLVM_CONFIG) --includedir)          \
> -               -L$(shell $(LLVM_CONFIG) --libdir)              \
> -               -Wl,--start-group -lclang-cpp -Wl,--end-group   \
> -               $(shell $(LLVM_CONFIG) --libs Core option)      \
> -               $(shell $(LLVM_CONFIG) --system-libs)           \
> -               > $(@:.bin=.make.output) 2>&1
> -
>  -include $(OUTPUT)*.d
>
>  $(OUTPUT)test-libaio.bin:
> --
> 2.55.0
>