Re: [PATCH v5 1/2] perf: Add Raspberry Pi BCM2835 AXI PMU driver

On 8/12/26 16:07, Ian Rogers wrote:
> This commit adds an uncore performance monitoring unit (PMU) driver
> for Broadcom BCM2835-BCM2711 AXI system monitors and VideoCore VPU firmware
> mailbox monitors found on Raspberry Pi 1 through 4.

Missing generative AI tags here?

> 
> Signed-off-by: Ian Rogers <[email protected]>
> ---
>   drivers/perf/Kconfig       |   10 +
>   drivers/perf/Makefile      |    1 +
>   drivers/perf/rpi_axi_pmu.c | 1793 ++++++++++++++++++++++++++++++++++++
>   3 files changed, 1804 insertions(+)
>   create mode 100644 drivers/perf/rpi_axi_pmu.c

This is more applicable to the second part of the patch, but the 
dependency on the Raspberry Pi firmware interface bothers me a bit. We 
have the AXI PMU blocks available on the 7712/77122 chips which are 
sister chips to the 2712, we don't run the Raspberry Pi firmware on 
those systems however.

Once your patches land, I will see if I can get generative AI to help me 
add support for the two AXI PMUs that exist on those chips.

Thanks for doing this!
-- 
Florian