Re: [PATCH v8 2/9] perf c2c: add function view browser skeleton
Jiebin Sun <[email protected]>
| Newsgroups | org.kernel.vger.linux-perf-users,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Namhyung, > Considering function view in stdio, wouldn't it be better to move the > common code to util/c2c.c instead? Good point. Since this series only adds the TUI function view and has no stdio caller yet, I would prefer to defer the split until stdio support is implemented, when the shared interface is clearer. Would that be acceptable? If you prefer the separation in this series, I can move the common model to a separate util/c2c-function.c and keep the TUI code in ui/browsers/c2c-function.c. Thanks, Jiebin