Re: [PATCH v8 2/9] perf c2c: add function view browser skeleton

Namhyung Kim <[email protected]>
Newsgroups org.kernel.vger.linux-perf-users,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Fri, Aug 14, 2026 at 11:23:04AM +0800, Jiebin Sun wrote:
> Hi Namhyung,
> 
> > Considering function view in stdio, wouldn't it be better to move the
> > common code to util/c2c.c instead?
> 
> Good point. Since this series only adds the TUI function view and has no
> stdio caller yet, I would prefer to defer the split until stdio support is
> implemented, when the shared interface is clearer.

My concern is that the later split would move the code as is and just
make the history complex unnecessarily.

> 
> Would that be acceptable? If you prefer the separation in this series, I
> can move the common model to a separate util/c2c-function.c and keep the
> TUI code in ui/browsers/c2c-function.c.

Let's start with things very clearly separated.  It's up to you but I
prefer having obviously common code in the common location.

Thanks,
Namhyung
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.