Re: [PATCH v8 2/9] perf c2c: add function view browser skeleton
Jiebin Sun <[email protected]>
| Newsgroups | org.kernel.vger.linux-perf-users,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Namhyung, > Let's start with things very clearly separated. It's up to you but I > prefer having obviously common code in the common location. That makes sense. I'll make the split in v9 to avoid a move-only change later. The new util/c2c-function.c will hold the hierarchy construction, aggregation, sorting, HPP formatting, and original-cacheline lookup. The ui/browsers/c2c-function.c file will retain the browser object, key loop, and cacheline detail callback. Thanks, Jiebin