Re: [PATCH v2 3/4] perf tools: Add support for displaying weights in annotate

Andi Kleen <[email protected]>
Newsgroups org.kernel.vger.linux-perf-users
Message-ID <an8p-1D0jNgE8P4T@tassilo>
On Fri, Aug 14, 2026 at 03:19:45PM +0900, Namhyung Kim wrote:
> >  	 * symbol and are missed.
> > @@ -719,6 +720,8 @@ int cmd_annotate(int argc, const char **argv)
> >  	OPT_BOOLEAN(0, "tui", &annotate.use_tui, "Use the TUI interface"),
> >  #endif
> >  	OPT_BOOLEAN(0, "stdio", &annotate.use_stdio, "Use the stdio interface"),
> > +	OPT_BOOLEAN(0, "no-weights", &symbol_conf.hide_weight,
> > +		    "Hide weight columns in annotation"),
> 
> Can it be just "weights"?  Then we would get --no-weights for free. :)
> Of course, the help message needs to say differently.

Sure I can rename it.

BTW this was the v2 with the broken white space hunks, please ignore or look at v3.

-Andi
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.