Re: [PATCH v2 1/3] perf/x86: Add x86_pmu::print_debug
| Newsgroups | org.kernel.vger.linux-perf-users |
|---|---|
| Message-ID | <[email protected]> |
> perf_event_print_debug() dumps the global control and status MSRs > whenever x86_pmu.version >= 2, reading registers that exist only on > Intel-compatible PMUs. This is not safe since x86_pmu.version is not > Intel-specific and is now set by other vendors whose global registers > use different addresses. > > As a first step, split perf_event_print_debug() in two. The register > dump moves into a new common helper, x86_pmu_print_debug(), leaving > perf_event_print_debug() to handle the preamble and dispatch to an > optional x86_pmu::print_debug method. This lets each vendor-specific > PMU dump its own global state before chaining into the common helper. > PMUs that do not implement the method, such as those with > x86_pmu.version < 2, get the common helper alone. > > No functional change intended. > > Signed-off-by: Sandipan Das <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1