Re: [PATCH v13 1/3] dt-bindings: perf: Add Broadcom Raspberry Pi AXI PMU definition

Uwe Kleine-König <[email protected]> Sat, 15 Aug 2026 23:39:42 +0200

Newsgroups	org.kernel.vger.linux-perf-users,dev.linux.lists.sashiko-reviews
Message-ID	<aoDZrWaC20bfc2jX@monoceros>

On Sat, Aug 15, 2026 at 05:30:49PM +0000, [email protected] wrote:
> > Add Device Tree bindings for the Broadcom AXI PMU hardware blocks present
> > in the Raspberry Pi SoC line (BCM2835, BCM2711, BCM2712).
> > 
> > Depending on the SoC and security configuration, these PMUs support either
> > direct MMIO access or routing via the Raspberry Pi firmware Mailbox IPC.
> > The bindings support defining 1 or 2 backing MMIO regions natively map
> > the system and VPU control surfaces.
> > 
> > Assisted-by: Antigravity:gemini-3.6-flash
> > Signed-off-by: Ian Rogers <[email protected]>
> 
> Sashiko has reviewed this patch and found no issues. It looks great!

While Sashiko doesn't find issues any more, checkpatch still does. It
(rightfully!) criticizes usage of LINUX_VERSION_CODE which is unsuitable
for mainline inclusion.

Florian already pointed that out in reply to v10 or v11 (these two
versions were not marked with a vX and I don't feel like doing the
detective work to find that out. Usually you can see that using the Date
they were sent, but they were sent on the same day and both in reply to
v9 (which was also sent the same day 🙄)). Sad Ian knew better and
continued using LINUX_VERSION_CODE. :-(

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)