[RFC PATCH] perf/amd/ibs: Report physical address for IBS fetch samples
Huang Shijie <[email protected]>
| Newsgroups | org.kernel.vger.linux-perf-users,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
The IBS Fetch sampling does not report the physical address of the fetched instruction even when PERF_SAMPLE_PHYS_ADDR is requested, while IBS Op sampling does. This patch reports physical address for IBS fetch samples which can be used for profiling the running program. Signed-off-by: Huang Shijie <[email protected]> --- arch/x86/events/amd/ibs.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 3531f9c23b8c..e5376ad5b2ec 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -1318,11 +1318,31 @@ static void perf_ibs_parse_ld_st_data(__u64 sample_type, } } +static void perf_ibs_parse_fetch_data(__u64 sample_type, + struct perf_ibs_data *ibs_data, + struct perf_sample_data *data) +{ + union ibs_fetch_ctl fetch_ctl; + + if (!(sample_type & PERF_SAMPLE_PHYS_ADDR)) + return; + + fetch_ctl.val = ibs_data->regs[ibs_fetch_msr_idx(MSR_AMD64_IBSFETCHCTL)]; + if (!fetch_ctl.phy_addr_valid) + return; + + data->phys_addr = ibs_data->regs[ibs_fetch_msr_idx(MSR_AMD64_IBSFETCHPHYSAD)]; + data->sample_flags |= PERF_SAMPLE_PHYS_ADDR; +} + static bool perf_ibs_is_mem_sample_type(struct perf_ibs *perf_ibs, struct perf_event *event) { u64 sample_type = event->attr.sample_type; + if (perf_ibs == &perf_ibs_fetch) + return sample_type & PERF_SAMPLE_PHYS_ADDR; + return perf_ibs == &perf_ibs_op && sample_type & (PERF_SAMPLE_DATA_SRC | PERF_SAMPLE_WEIGHT_TYPE | @@ -1555,6 +1575,8 @@ static int perf_ibs_handle_irq(struct perf_ibs *perf_ibs, struct pt_regs *iregs) if (perf_ibs == &perf_ibs_op) perf_ibs_parse_ld_st_data(event->attr.sample_type, &ibs_data, &data); + else + perf_ibs_parse_fetch_data(event->attr.sample_type, &ibs_data, &data); /* * rip recorded by IbsOpRip will not be consistent with rsp and rbp -- 2.53.0