Re: [PATCH v9 3/9] perf c2c: add column rendering for function view
| Newsgroups | org.kernel.vger.linux-perf-users |
|---|---|
| Message-ID | <[email protected]> |
> Add renderers for the function view's Cycles %, Store count, and > hierarchy identity columns. The identity column renders the read-side > function, contending writer, or cacheline, with indentation for the > hierarchy level. Also add width and header helpers, estimated-cycle > calculation, comparators, and the dimension table that ties them together. > > Clamp the identity renderer's returned length to its local buffer before > using it for pointer and padding calculations. This handles snprintf-style > would-have-been lengths without changing normal output. > > The next patch connects these dimensions to the view's HPP lists, so the > symbols used only there are temporarily marked __maybe_unused. > > Signed-off-by: Jiebin Sun <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3