Re: [PATCH v9 6/9] perf c2c: add function view hierarchy entry creation
| Newsgroups | org.kernel.vger.linux-perf-users |
|---|---|
| Message-ID | <[email protected]> |
> Add the entry-creation layer: owned-reference child allocation and > insertion, and the level-1/2/3 lookup-or-create functions keyed by > function symbol (level 1 read-side, level 2 writer) and by the source > cacheline's existing index (level 3). > > Give synthetic children normal entry operations and acquire their thread > and map-symbol references. This lets the hierarchy teardown use > hist_entry__delete() for the common fields while the function-view free > callback handles the private child tree and containing allocation. > > Reuse cacheline_idx to preserve the source entry identity without adding > function-view-only state. Add c2c_function__find_cacheline() to locate the > original cacheline entry by the same index. > > These are driven by the hierarchy builder in the next patch and are > __maybe_unused until then. > > Signed-off-by: Jiebin Sun <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6