Re: [PATCH v9 1/9] perf c2c: extract shared data structures into util/c2c.h
| Newsgroups | org.kernel.vger.linux-perf-users |
|---|---|
| Message-ID | <[email protected]> |
> The function browser belongs in libperf-ui.a, but that archive is also > linked into python/perf.so, where builtin command objects are unavailable. > The browser therefore cannot depend on types or callbacks owned by > builtin-c2c.c. > > Move c2c_hists, compute_stats, c2c_hist_entry, and the shared column > formatting definitions from builtin-c2c.c to a new util/c2c.h. Move > c2c_fmt_free() and c2c_fmt_equal() to a new util/c2c.c. > > Keep struct perf_c2c, the command instance, and > perf_c2c__browse_cacheline() private to builtin-c2c.c. > > No functional change. > > Signed-off-by: Jiebin Sun <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1