Re: [RFC PATCH] perf/amd/ibs: Report physical address for IBS fetch samples
Peter Zijlstra <[email protected]>
| Newsgroups | org.kernel.vger.linux-perf-users,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 18, 2026 at 10:29:08AM +0530, Ravi Bangoria wrote: > On 17-Aug-26 1:03 PM, Huang Shijie wrote: > > The IBS Fetch sampling does not report the physical address of the > > fetched instruction even when PERF_SAMPLE_PHYS_ADDR is requested, > > while IBS Op sampling does. > > > > This patch reports physical address for IBS fetch samples which can be > > used for profiling the running program. > > PERF_SAMPLE_PHYS_ADDR is meant to capture the _data_ physical address, which > IBS Fetch doesn't provide. So, repurposing semantics of PERF_SAMPLE_PHYS_ADDR > for IBS Fetch seems reasonable. > > Reviewed-by: Ravi Bangoria <[email protected]> Well, why confuse things? As you say, PHYS_ADDR is for ADDR, which is the *data* address, and FETCH is an instruction address, which we find in IP, not DATA. What would be the purpose of confusing things and making PHYS_ADDR relate to IP?