Re: [PATCH 3/6] perf cs-etm: Synthesize missing HW_ID mappings for raw trace

[email protected]
Newsgroups org.kernel.vger.linux-perf-users
Message-ID <[email protected]>
> From: Leo Yan <[email protected]>
> 
> The CoreSight driver emits PERF_RECORD_AUX_OUTPUT_HW_ID via
> perf_report_aux_output_id(). If the perf ring buffer is full,
> perf_report_aux_output_id() can fail to emit the record and return
> silently.
> 
> When at least one HW_ID record is present in the file, perf skips the
> legacy metadata-only trace ID mapping path. Therefore any raw AUX queue
> whose HW_ID record was dropped can be left with an empty traceid_list,
> and cs_etm__create_queue_decoders() will not create a decoder for that
> queue.
> 
> Backfill missing mappings for non-empty UNFORMATTED queues whose trace
> ID map is still empty after the HW_ID record scan. Real HW_ID mappings
> remain preferred and are not overwritten in case someone is trying to
> link what the kernel outputs to the raw trace dump.
> 
> Signed-off-by: Leo Yan <[email protected]>
> Signed-off-by: James Clark <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821-james-cs-hw_id-output-failure-v1-0-9d532ddabcc3@linaro.org?part=3
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.