Re: [PATCH v13 03/12] x86/hw_breakpoints: Add arch_modify_local_hw_breakpoint_addr() API
| Newsgroups | org.kernel.vger.linux-perf-users,org.kernel.vger.linux-trace-kernel |
|---|---|
| Message-ID | <[email protected]> |
> From: Jinchao Wang <[email protected]> > > Wprobe needs to move an active per-CPU watchpoint without releasing and > reserving its hardware slot. > > Add arch_modify_local_hw_breakpoint_addr() as the architecture backend for > modify_local_hw_breakpoint_addr(). It validates the new address, finds the > installed local slot, and updates the hardware debug register and per-CPU > shadow register. The core layer (modify_local_hw_breakpoint_addr()) handles > updating bp->attr.bp_addr and counter_arch_bp(bp)->address. > > The caller must provide an installed local event and a valid address. > Slot ownership, breakpoint type, length, mask and DR7 remain unchanged. > > Link: https://lore.kernel.org/all/59637b96946653393a7ad3c7de094094796b39c2.1785067572.git.wangjinchao600@gmail.com/ > > Signed-off-by: Jinchao Wang <[email protected]> > Signed-off-by: Masami Hiramatsu (Google) <[email protected]> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/178739053919.1520941.17662338993878200834.stgit@devnote2?part=3