Re: [PATCH v2 2/3] time/jiffies: Include linux/sysctl.h for proc_int_u2k_conv_uop(), ...
Petr Pavlu <[email protected]>
| Newsgroups | org.kernel.vger.linux-pm,dev.linux.lists.bridge,dev.linux.lists.drbd-dev,dev.linux.lists.driver-core,dev.linux.lists.ocfs2-devel,org.freedesktop.lists.dri-devel,org.kernel.vger.cgroups,org.kernel.vger.keyrings,org.kernel.vger.linux-acpi,org.kernel.vger.linux-block,org.kernel.vger.linux-edac,org.kernel.vger.linux-fbdev,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-security-module,org.kernel.vger.netdev,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On 7/25/26 10:31 PM, Thomas Gleixner wrote:
> On Tue, Jul 21 2026 at 15:11, Petr Pavlu wrote:
>
>> The kernel/time/jiffies.c file uses proc_int_u2k_conv_uop(),
>
> jiffies.c uses ...
>
>> proc_int_k2u_conv_kop(), proc_int_conv(), proc_dointvec_conv() and
>> proc_doulongvec_minmax_conv(), which are declared in linux/sysctl.h. It
>> currently relies on this header being included indirectly through
>> linux/module.h -> linux/kmod.h. Add the missing include in preparation for
>> removing the linux/sysctl.h include from linux/kmod.h.
>
> Can you please split that spaghetti sentence into paragraphs?
>
> https://docs.kernel.org/process/maintainer-tip.html#changelog
I will update it to:
jiffies.c uses proc_int_u2k_conv_uop(), proc_int_k2u_conv_kop(),
proc_int_conv(), proc_dointvec_conv() and proc_doulongvec_minmax_conv(),
which are declared in linux/sysctl.h. It currently gets that header
indirectly through linux/module.h -> linux/kmod.h, but the latter no longer
needs to include linux/sysctl.h.
Include linux/sysctl.h directly in jiffies.c ahead of removing the
unnecessary include from linux/kmod.h.
>
>> Signed-off-by: Petr Pavlu <[email protected]>
>
> Other than that.
>
> Acked-by: Thomas Gleixner <[email protected]>
--
Thanks,
Petr