Re: [RFC PATCH 1/4] cpufreq/amd-pstate: Document missing kernel-doc members

On 7/28/26 02:31, David Vernet wrote:
> kernel-doc warns about five undescribed members in amd-pstate.h:
> union perf_cached's @val and struct amd_cpudata's @raw_epp,
> @current_profile, @ppdev and @profile_name. Describe them.
> 
> Signed-off-by: David Vernet <[email protected]>
> ---
>   drivers/cpufreq/amd-pstate.h | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
> index 23e8baa05849..99532595150e 100644
> --- a/drivers/cpufreq/amd-pstate.h
> +++ b/drivers/cpufreq/amd-pstate.h
> @@ -32,6 +32,7 @@
>    * @min_limit_perf: Cached value of the performance corresponding to policy->min
>    * @max_limit_perf: Cached value of the performance corresponding to policy->max
>    * @bios_min_perf: Cached perf value corresponding to the "Requested CPU Min Frequency" BIOS option
> + * @val: Raw 64-bit value for atomic access via READ_ONCE()/WRITE_ONCE()
>    */
>   union perf_cached {
>   	struct {
> @@ -89,7 +90,12 @@ struct amd_aperf_mperf {
>    * @epp_default_ac: Default EPP value for AC power source
>    * @epp_default_dc: Default EPP value for DC power source
>    * @dynamic_epp: Whether dynamic EPP is enabled
> + * @raw_epp: Whether the last EPP write was a raw numeric value rather than a
> + *	     named preference
>    * @power_nb: Notifier block for power events
> + * @current_profile: Currently selected platform profile option
> + * @ppdev: Device registered with the platform profile handler
> + * @profile_name: Name under which @ppdev is registered
>    *
>    * The amd_cpudata is key private data for each CPU thread in AMD P-State, and
>    * represents all the attributes and goals that AMD P-State requests at runtime.

Thanks!

This is a pure doc fix.  I'll pick it up from the series to include in 
my 7.3 PR later this week.

Acked-by: Mario Limonciello (AMD) <[email protected]>