Re: [RFC PATCH v2 2/8] pmdomain/rockchip: add optional per-domain power-on settle delay

Heiko Stübner <[email protected]>
Newsgroups org.kernel.vger.linux-pm,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel
Message-ID <10568528.L8ug28u51p@diego>
Am Donnerstag, 30. Juli 2026, 13:32:38 Mitteleuropäische Sommerzeit schrieb Jiaxing Hu:
> Hi Heiko,
> 
> Thanks for looking.
> 
> Understood on the naming. The suffixes describe the fields the macro
> sets, so a variant that also carries a wakeup delay should say so. In v3
> I will add
> 
>   DOMAIN_M_O_R_G_W(..., g_mask, delay, wakeup)
> 
> and leave DOMAIN_M_O_R_G with its current signature, with DOMAIN_RK3576
> switched over to the _W form. That also keeps the diff off the macro
> every other SoC goes through, which is nicer than what I sent.
> 
> One note while I am there: DOMAIN_RK3576 is DOMAIN_M_O_R_G's only
> in-tree user, so after this the plain form has no callers left. I will
> keep it as you asked; say the word if you would rather it just gained
> the parameter after all.

Please this ... i.e. not keep the then unused variant around.
As you said RK3576 is the only user, so just rename that DOMAIN_*
macro please.

Heiko
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.