RE: [PATCH 2/3] power: sequencing: Add Renesas RZ/G3L Power Ready driver
Biju Das <[email protected]> Sat, 1 Aug 2026 13:06:43 +0000
| Newsgroups | org.kernel.vger.linux-pm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <TY3PR01MB1134645360B0F4940B71DB80E86D72@TY3PR01MB11346.jpnprd01.prod.outlook.com> |
Hi Bartosz Golaszewski, > -----Original Message----- > From: Bartosz Golaszewski <[email protected]> > Sent: 30 July 2026 09:52 > Subject: Re: [PATCH 2/3] power: sequencing: Add Renesas RZ/G3L Power Ready driver > > On Wed, 29 Jul 2026 16:33:31 +0200, Biju Das <[email protected]> said: > > > > Here it is. Please find the relevant DT nodes usbphy-ctrl [1] and dsi > > [2] > > > > [1] > > https://lore.kernel.org/all/[email protected] > > esas.com/ [2] > > https://lore.kernel.org/all/[email protected] > > nesas.com/ > > > > So the sysc is the parent of the power sequencer but there's no relation between it and the consumers > modeled in DT? > > In that case some validation is still required: you should make sure the consumer device is compatible > with a list of devices we can service. sysc and consumers also seem to share the parent node so that's > worth checking too. > > We shouldn't just return MATCH_OK for anyone that comes knocking. OK, will add below matching in V3: +static int pwrseq_rzg3l_pwrrdy_match(struct pwrseq_device *pwrseq, + struct device *dev) +{ + static const struct of_device_id pwrseq_rzg3l_consumer_match[] = { + { .compatible = "renesas,r9a08g046-mipi-dsi" }, + { .compatible = "renesas,r9a08g046-usbphy-ctrl" }, + { /* sentinel */ } + }; + const struct of_device_id *match; + + match = of_match_device(pwrseq_rzg3l_consumer_match, dev); + if (!match) + return PWRSEQ_NO_MATCH; + + return PWRSEQ_MATCH_OK; +} Cheers, Biju