Re: [PATCH] cpupower: Avoid uninitialized reads in topology sorting

On 8/3/26 10:36, Ali Ahmet Memis wrote:
> On Mon, Aug 03, 2026 at 10:29:15AM -0600, Shuah wrote:
>> Sorry I am not taking this patch.
>>
>> Please note that build test just verifies that the code build which
>> fall way short of testing the changed code.
> 
> First, sorry about the duplicates. The mail provider I was using at the
> time rewrote the Message-ID and delivered the same patch several times, so
> it hit the list as a handful of separate threads. That was not me resending
> it. I have moved off that provider and everything since August 1 goes out
> with a stable Message-ID from git send-email.
> 

I noticed the duplicates. I am glad you switched to git send-email.

> The valgrind run was in the notes under the scissors, not just a build: a
> two-CPU mock where CPU1's topology reads fail, uninitialized reads in
> __compare_core_cpu_list() before the patch and none after. If there is
> testing you would want beyond that, tell me what would satisfy you and I
> will do it. Otherwise I am fine dropping this.

I missed that. There is no need to say the patch was build-tested since
you did mock testing.

This patch is doing more than replacing malloc() with calloc(). Please
split the changes into separate patches.

thanks,
-- SHuah