Re: [PATCH 1/7] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen4 ADC

Hi Jonathan,

On 8/3/2026 5:19 AM, Jonathan Cameron wrote:
> On Fri, 31 Jul 2026 23:36:14 +0530
> Jishnu Prakash <[email protected]> wrote:
> 
>> PMIC5 Gen4 ADC is similar to PMIC5 Gen3 ADC, with several changes made for
>> improved performance, mostly at the hardware level. The main differences are
>> increased ratiometric conversion resolution (from 14 bits to 16 bits) and
>> increased bit field width for PMIC SID (to allow communication with an
>> increased number of PMICs, supported on latest SoCs).
> 
> Hi Jishnu,
> 
> The mixed case is enough of a surprise (to me least) that I'd expect
> there to either be more discussion here or for it to be handled first
> as a dt binding patch to allow for v4 channels on v3 hardware.
> 

If I understand your comment correctly, you mean I should either add a
description of the mixed cases in the commit message, or split the
patch - one patch to add the new compatible and one to add the new
channel properties ?

I think it's slightly better to add details in the commit message
and keep the changes in a single patch. What do you think ?

Thanks,
Jishnu


> That would provide a place for a description of why that is necessary and
> then the following gen4 dt-bindings patch with gen3 channels would seem
> like a natural extension.
> 
> Other than that this seems fine to me.
> 
> Jonathan
> 
>>
>> Signed-off-by: Jishnu Prakash <[email protected]>
>> ---
>>  .../bindings/iio/adc/qcom,spmi-adc5-gen3.yaml      | 47 +++++++++++++++++++++-
>>  1 file changed, 46 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-adc5-gen3.yaml