Re: [PATCH] power: supply: bq256xx: drain usb_work before freeing the charger
Sebastian Reichel <[email protected]>
| Newsgroups | org.kernel.vger.linux-pm,org.kernel.vger.linux-kernel,org.kernel.vger.stable |
|---|---|
| Message-ID | <178657343055.347615.13631525717125029923.b4-ty@b4> |
On Tue, 04 Aug 2026 14:55:11 +0000, Fan Wu wrote:
> The USB-PHY notifier queues usb_work, whose handler calls
> power_supply_changed(bq->charger). The reset devm action only unregisters
> the notifier and was registered before the power supplies, so devm frees
> bq->charger on unwind before the action runs; a usb_work still queued can
> then dereference it.
>
> Register the reset action after the power supplies, so it unregisters
> the notifiers and drains usb_work before the supplies are released.
> Initialize usb_work and obtain the PHY references before registering
> the notifiers, so the worker cannot run before the supplies exist.
>
> [...]
Applied, thanks!
[1/1] power: supply: bq256xx: drain usb_work before freeing the charger
commit: 2dd6cd823777bea6d9a880a12a92a73ec76aee0b
Best regards,
--
Sebastian Reichel <[email protected]>