Re: [PATCH 2/7] soc: qcom: geni-se: Populate clk_perf_tbl with SE source clock frequencies from perf OPP table
Praveen Talari <[email protected]>
| Newsgroups | org.kernel.vger.linux-pm,org.infradead.lists.linux-arm-kernel,org.kernel.vger.arm-scmi,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel,org.kernel.vger.linux-serial,org.kernel.vger.linux-spi |
|---|---|
| Message-ID | <[email protected]> |
HI Konrad,
On 24-08-2026 20:26, Konrad Dybcio wrote:
> On 8/4/26 9:57 PM, Praveen Talari wrote:
>> Currently, on the SA8255P platform, protocol drivers attached via
>> geni_se_domain_attach() treat each OPP on the perf domain as directly
>> corresponding to a protocol value such as a baudrate or requested
>> frequency, and simply request that OPP via
> [...]
>
>> @@ -1175,6 +1181,29 @@ int geni_se_domain_attach(struct geni_se *se)
>> else if (ret < 0)
>> return ret;
>>
>> + perf_dev = se->pd_list->pd_devs[DOMAIN_IDX_PERF];
>> +
>> + num_opps = dev_pm_opp_get_opp_count(perf_dev);
>> + if (num_opps <= 0)
>> + return num_opps < 0 ? num_opps : -ENODEV;
> if (num_opps < 0)
> return num_opps;
> if (num_opps == 0)
> return -ENODEV;
Sure, will update in next patch.
>
>> +
>> + se->clk_perf_tbl = devm_kcalloc(se->dev, num_opps,
>> + sizeof(*se->clk_perf_tbl),
>> + GFP_KERNEL);
>> + if (!se->clk_perf_tbl)
>> + return -ENOMEM;
>> +
>> + for (i = 0, level = 0; i < num_opps; i++, level++) {
> One iterator is sufficient here
Will review and update.
Thanks,
Praveen Talari
>
> Konrad