Re: [PATCH 2/2] arm64: dts: qcom: sm6125: add TSENS and thermal zones

On 8/21/26 5:03 AM, Roman Linev wrote:
> SM6125 has a TSENS v2 controller with 16 sensors, at 0x04411000 (TM) and
> 0x04410000 (SROT), with SPI 275 as "uplow" and SPI 190 as "critical".
> The register and interrupt layout is identical to SM6115's, and being v2
> the block self-calibrates, so it needs no qfprom nvmem cells and no new
> driver code: it binds through the existing qcom,tsens-v2 fallback.
> 
> Add the controller and thermal zones for the 15 sensors that are used.
> The sensor-to-zone mapping comes from the downstream device tree for
> Xiaomi Mi A3 (laurel_sprout), cross-checked against mainline sm6115.dtsi,
> which agrees on sensors 2, 3, 4, 13, 14 and 15. Sensor 5 is not
> referenced downstream and is left out.
> 
> No cooling devices are wired up: SM6125 has no GPU node upstream yet, so
> there is nothing to reference. The zones report temperature and carry
> passive and critical trips; cooling maps can be added alongside the
> consumers when those land.

CPUs are good candidates too

[...]

> +		tsens0: thermal-sensor@4411000 {
> +			compatible = "qcom,sm6125-tsens", "qcom,tsens-v2";
> +			reg = <0x0 0x04411000 0x0 0x1ff>, /* TM */
> +			      <0x0 0x04410000 0x0 0x8>; /* SROT */

Let's drop the comments and make the regions 0x1000-long

[...]

> +	thermal-zones {
> +		/*
> +		 * Sensor-to-zone mapping verified against the downstream
> +		 * laurel_sprout device tree (tsens@4410000, sensors 0..15) and

Very good

> +		 * cross-checked with mainline sm6115.dtsi, which agrees on

This is a different SoC, you shouldn't rely on that


> +		 * sensors 2, 3, 4, 13, 14 and 15. Sensor 5 is unused by the
> +		 * downstream tree and is therefore left out.

and the docs confirm that it's unused

I think this comment should be dropped, these details seem more fitting
for a commit message

Konrad