Re: [RFC PATCH net-next v3] ppp: use IFF_NO_QUEUE in virtual interfaces

Qingfang Deng <[email protected]> writes:

> For PPPoE, PPTP, and PPPoL2TP, the start_xmit() function directly
> forwards packets to the underlying network stack and never returns
> anything other than 1. So these interfaces do not require a qdisc,
> and the IFF_NO_QUEUE flag should be set.
>
> Introduces a direct_xmit flag in struct ppp_channel to indicate when
> IFF_NO_QUEUE should be applied. The flag is set in ppp_connect_channel()
> for relevant protocols.
>
> Signed-off-by: Qingfang Deng <[email protected]>
> ---
> v3:
>   Move direct_xmit above the unused "latency" member to avoid
>   confusion. Should I remove it instead?

If it really is unused, I think removing it is better to remove it,
yeah :)

-Toke