Re: [PATCH net-next] ppp: use IFF_NO_QUEUE in virtual interfaces

Toke Høiland-Jørgensen <[email protected]> Mon, 03 Mar 2025 11:28:39 +0100
Newsgroups org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <[email protected]>
Qingfang Deng <[email protected]> writes:

> For PPPoE, PPTP, and PPPoL2TP, the start_xmit() function directly
> forwards packets to the underlying network stack and never returns
> anything other than 1. So these interfaces do not require a qdisc,
> and the IFF_NO_QUEUE flag should be set.
>
> Introduces a direct_xmit flag in struct ppp_channel to indicate when
> IFF_NO_QUEUE should be applied. The flag is set in ppp_connect_channel()
> for relevant protocols.
>
> While at it, remove the usused latency member from struct ppp_channel.
>
> Signed-off-by: Qingfang Deng <[email protected]>

Reviewed-by: Toke Høiland-Jørgensen <[email protected]>