Re: [PATCH net-next v3 0/1] ppp: Replace per-CPU recursion counter with lock-owner field

Guillaume Nault <[email protected]> Tue, 15 Jul 2025 19:37:37 +0200
Newsgroups org.kernel.vger.linux-ppp,dev.linux.lists.linux-rt-devel,org.kernel.vger.netdev
Message-ID <aHaR4QzKvCDi/LYx@debian>
On Tue, Jul 15, 2025 at 05:08:05PM +0200, Sebastian Andrzej Siewior wrote:
> This is another approach to avoid relying on local_bh_disable() for
> locking of per-CPU in ppp.
> 
> I redid it with the per-CPU lock and local_lock_nested_bh() as discussed
> in v1. The xmit_recursion counter has been removed since it served the
> same purpose as the owner field. Both were updated and checked.
> 
> The xmit_recursion looks like a counter in ppp_channel_push() but at
> this point, the counter should always be 0 so it always serves as a
> boolean. Therefore I removed it.
> 
> I do admit that this looks easier to review.

Thanks!

Reviewed-by: Guillaume Nault <[email protected]>