Re: [PATCH net-next v4] net: pppoe: implement GRO/GSO support

Qingfang Deng <[email protected]> Mon, 2 Mar 2026 15:34:18 +0800
Newsgroups org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <CALW65jbAGUxsyNw229uHks92T3Vr1iuFs=hVeTB3N9awAuZVXg@mail.gmail.com>
On Sat, Feb 28, 2026 at 11:23 AM Qingfang Deng <[email protected]> wrote:
> +       /* ignore packets with padding or invalid length */
> +       if (skb_gro_len(skb) != be16_to_cpu(phdr->length) + hlen)

Both Claude (Netdev AI Review) and Gemini said `hlen` should be
replaced with `sizeof(*phdr)`. Is that correct?