Re: [PATCH net-next] ppp: require callers of ppp_dev_name() to hold RCU
Breno Leitao <[email protected]> Tue, 17 Mar 2026 13:05:23 -0700
| Newsgroups | org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Mar 16, 2026 at 05:28:23PM +0800, Qingfang Deng wrote: > ppp_dev_name() holds the RCU read lock internally to protect pch->ppp. > However, as it returns netdev->name to the caller, the caller should > also hold either RCU or RTNL lock to prevent the netdev from being > freed. > > The only two references of the function is in the L2TP driver, both of nit: The only two references of the function *are*... > which already hold RCU. So remove the internal RCU lock and document > that callers must hold RCU. This symbol is also exported, but, we don't care if external drivers call it without holding the RCU read lock. > Signed-off-by: Qingfang Deng <[email protected]> Reviewed-by: Breno Leitao <[email protected]>