Re: [PATCH net-next] selftests: net: add tests for PPP

Qingfang Deng <[email protected]> Sat, 21 Mar 2026 20:34:09 +0800

Newsgroups	org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.netdev
Message-ID	<CALW65jajTpzKPAfc3nNpKeBOLbqqP7LZjaNaq6Eji1G17ZzKkw@mail.gmail.com>

On Sat, Mar 21, 2026 at 4:58 PM Simon Horman <[email protected]> wrote:
>
> On Fri, Mar 20, 2026 at 03:17:54PM +0800, Qingfang Deng wrote:
> > Add ping and iperf3 tests for ppp_async.c and pppoe.c.
> >
> > Signed-off-by: Qingfang Deng <[email protected]>
> > ---
> >  MAINTAINERS                                   |  1 +
> >  tools/testing/selftests/Makefile              |  1 +
> >  tools/testing/selftests/net/ppp/Makefile      | 15 +++++++
> >  tools/testing/selftests/net/ppp/config        |  8 ++++
> >  tools/testing/selftests/net/ppp/ppp_async.sh  | 37 +++++++++++++++++
> >  tools/testing/selftests/net/ppp/ppp_common.sh | 40 +++++++++++++++++++
>
> Shellcheck flags two issues in ppp_common.sh. As we are aiming
> for new tests to be shellcheck-clean I'd appreciate it if you could
> look into this.

Okay, I'll fix the shellcheck issues and the trailing backslashes in v2.