Re: [PATCH net-next v5] net: pppoe: implement GRO/GSO support
Xin Long <[email protected]> Thu, 26 Mar 2026 10:43:54 -0400
| Newsgroups | org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <CADvbK_f3LwEt+-BG-1Pcr4jMn6Jxry+0p-Fu_s0C6Px+F_NHCA@mail.gmail.com> |
On Thu, Mar 26, 2026 at 10:43 AM Xin Long <[email protected]> wrote: > > On Wed, Mar 25, 2026 at 10:43 PM Qingfang Deng <[email protected]> wrote: > > > > Hi all, > > > > In some cases (such as BIG TCP) a GRO skb length can overflow a u16, > > then what should I do with the u16 length field here? > > I think you can either add a check in pppoe_gro_complete() to ensure sorry, I meant add a check in pppoe_gro_receive(). > the aggregated size does not exceed U16_MAX, avoiding BIG TCP > behavior; Or, set phdr->length to 0 and rely on skb->len to determine > the actual length, as done in BIG TCP itself.