Re: [PATCH net-next v2] ppp: update Kconfig help message

Hi,

On 2026/04/02 07:00, Qingfang Deng wrote:
> Both links of the PPPoE section are no longer valid, and the CVS version
> is no longer relevant.
>
> - Replace the TLDP URL with the pppd project homepage.
> - Update pppd version requirement for PPPoE.
> - Update RP-PPPoE project homepage, and clarify that it's only needed
>    for server mode.
>
> Signed-off-by: Qingfang Deng <[email protected]>
FWIW:  Acked-by: Jaco Kroon <[email protected]>

Looks good to me.

> ---
> v2:
>   - replace TLDP URL with pppd homepage
>   - update pppd version requirement
>   - document that rp-pppoe is only required for server
>   https://lore.kernel.org/netdev/[email protected]/
>
>   drivers/net/ppp/Kconfig | 16 +++++++---------
>   1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig
> index f57fba84fe55..753354b4e36c 100644
> --- a/drivers/net/ppp/Kconfig
> +++ b/drivers/net/ppp/Kconfig
> @@ -13,10 +13,9 @@ config PPP
>   	  otherwise you can't use it; most Internet access providers these
>   	  days support PPP rather than SLIP.
>   
> -	  To use PPP, you need an additional program called pppd as described
> -	  in the PPP-HOWTO, available at
> -	  <http://www.tldp.org/docs.html#howto>.  Make sure that you have
> -	  the version of pppd recommended in <file:Documentation/Changes>.
> +	  To use PPP, you need an additional program called pppd, available at
> +	  <https://ppp.samba.org>.  Make sure that you have the version of pppd
> +	  recommended in <file:Documentation/Changes>.
>   	  The PPP option enlarges your kernel by about 16 KB.
>   
>   	  There are actually two versions of PPP: the traditional PPP for
> @@ -116,11 +115,10 @@ config PPPOE
>   	help
>   	  Support for PPP over Ethernet.
>   
> -	  This driver requires the latest version of pppd from the CVS
> -	  repository at cvs.samba.org.  Alternatively, see the
> -	  RoaringPenguin package (<http://www.roaringpenguin.com/pppoe>)
> -	  which contains instruction on how to use this driver (under
> -	  the heading "Kernel mode PPPoE").
> +	  To work in client mode, pppd version 2.4.2 or later is required.
> +	  To work in server mode, the pppoe-server command from the RP-PPPoE
> +	  package is also required, available at
> +	  <https://dianne.skoll.ca/projects/rp-pppoe/>.
>   
>   choice
>   	prompt "Number of PPPoE hash bits"