Re: [PATCH net v6 1/2] flow_dissector: do not dissect PPPoE PFC frames

[email protected] Mon, 20 Apr 2026 21:59:40 +0000
Newsgroups org.kernel.vger.linux-ppp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev
Message-ID <177672238004.1802062.14523487791539173606.git-patchwork-notify@kernel.org>
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 15 Apr 2026 10:24:50 +0800 you wrote:
> RFC 2516 Section 7 states that Protocol Field Compression (PFC) is NOT
> RECOMMENDED for PPPoE. In practice, pppd does not support negotiating
> PFC for PPPoE sessions, and the flow dissector driver has assumed an
> uncompressed frame until the blamed commit.
> 
> During the review process of that commit [1], support for PFC is
> suggested. However, having a compressed (1-byte) protocol field means
> the subsequent PPP payload is shifted by one byte, causing 4-byte
> misalignment for the network header and an unaligned access exception
> on some architectures.
> 
> [...]

Here is the summary with links:
  - [net,v6,1/2] flow_dissector: do not dissect PPPoE PFC frames
    https://git.kernel.org/netdev/net/c/d6c19b31a3c1
  - [net,v6,2/2] pppoe: drop PFC frames
    https://git.kernel.org/netdev/net/c/cc1ff87bce1c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html