Re: [PATCH net-next] ppp: reuse ppp_get_stats64() for ioctl stats

Hi Qingfang,

Thanks a lot for pointing this out.

> On a 32-bit architecture, this will introduce unnecessary seqlock
> overhead to get the upper 32-bit of a counter, which would then be
> immediately discarded.

That makes sense. I missed that reusing ppp_get_stats64() would add
unnecessary 64-bit stats read overhead on 32-bit architectures, while the
ioctl path only returns 32-bit counters. I agree this is not a good
trade-off for a cleanup.

Please ignore this patch.

Thanks again,
Zhixing