Re: [PATCH v19 1/3] dt-bindings: pwm: opencores: Update compatibles, examples and maintainers

> On 26.06.16 00:22, Conor Dooley wrote:
> On Mon, Jun 15, 2026 at 11:57:57PM +0800, Hal Feng wrote:
> > Remove the jh8100 compatible since the JH8100 SoC has been canceled
> > and will not be released. Add the jhb100 compatible to replace it.
> 
> > Use a oneOf construct to support the single-string opencores,pwm-v1
> > compatible.
> 
> No thanks. Simple as this IP might be, I still want soc-specific compatibles to be a
> requirement.
> pw-bot: changes-requested

Okay, will update accordingly. Thanks for your review.

Best regards,
Hal

> 
> >
> > Change the register size in examples to 0x10, since an OpenCores PTC
> > IP has only 4 32-bit registers: CNTR, HRC, LRC and CTRL.
> >
> > I will maintain this pwm module in place of William.
> >
> > Signed-off-by: Hal Feng <[email protected]>
> > ---
> >  .../devicetree/bindings/pwm/opencores,pwm.yaml   | 16 +++++++++-------
> >  1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
> > b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
> > index 52a59d245cdb..5f05606a2d3d 100644
> > --- a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
> > @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  title: OpenCores PWM controller
> >
> >  maintainers:
> > -  - William Qiu <[email protected]>
> > +  - Hal Feng <[email protected]>
> >
> >  description:
> >    The OpenCores PTC ip core contains a PWM controller. When operating
> > in PWM @@ -19,12 +19,14 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - starfive,jh7100-pwm
> > -          - starfive,jh7110-pwm
> > -          - starfive,jh8100-pwm
> > +    oneOf:
> >        - const: opencores,pwm-v1
> > +      - items:
> > +        - enum:
> > +            - starfive,jh7100-pwm
> > +            - starfive,jh7110-pwm
> > +            - starfive,jhb100-pwm
> > +        - const: opencores,pwm-v1
> >
> >    reg:
> >      maxItems: 1
> > @@ -49,7 +51,7 @@ examples:
> >    - |
> >      pwm@12490000 {
> >          compatible = "starfive,jh7110-pwm", "opencores,pwm-v1";
> > -        reg = <0x12490000 0x10000>;
> > +        reg = <0x12490000 0x10>;
> >          clocks = <&clkgen 181>;
> >          resets = <&rstgen 109>;
> >          #pwm-cells = <3>;
> > --
> > 2.43.2
> >