Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays
Uwe Kleine-König (The Capable Hub) <[email protected]>
| Newsgroups | org.kernel.vger.linux-pwm,dev.linux.lists.asahi,dev.linux.lists.chrome-platform,dev.linux.lists.imx,dev.linux.lists.linux-sunxi,dev.linux.lists.sophgo,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-mediatek,org.infradead.lists.linux-riscv,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-kernel,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-samsung-soc |
|---|---|
| Message-ID | <aktWoIfY_DdO6gb4@monoceros> |
Hello Chen,
On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote:
> On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote:
> > - Use a single space in a of_device_id array terminator; A single space
> > after the opening { and before the closing } in non-empty
> > initializers;
> > - No comma after an array terminator;
> > - Also no trailing comma after a named initializer iff the
> iff -> if
This is actually intended. iff = "if and only if", see e.g.
https://en.wikipedia.org/wiki/If_and_only_if .
> > closing } is on the same line;
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>
>
> [......]
>
> > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg2042.c
> > index 7d07b0ca7d29..0b6461172e6a 100644
> > --- a/drivers/pwm/pwm-sophgo-sg2042.c
> > +++ b/drivers/pwm/pwm-sophgo-sg2042.c
> > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_data = {
> > static const struct of_device_id sg2042_pwm_ids[] = {
> > {
> > .compatible = "sophgo,sg2042-pwm",
> > - .data = &sg2042_chip_data
> > - },
> > - {
> > + .data = &sg2042_chip_data,
> > + }, {
> > .compatible = "sophgo,sg2044-pwm",
> > - .data = &sg2044_chip_data
> > + .data = &sg2044_chip_data,
> > },
> > { }
> > };
>
> Changes to sophgo related files：
>
> Reviewed-by: Chen Wang <[email protected]>
Thanks
Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLVxEACgkQj4D7WH0S /k6otAf+MDN98V1OLHB7JSvapxuE4DwDpddJFumdMe3z/vu/P/VdI1oEao4PKhGo 2fMsJUgJT4k/6wIfoB6C3asAQFoEg3UirigbTf0d26+LpcWXfr+MJ/e2tzlX/Yzn 2dH88yKAhOR4HFj73YAi1FscS6vtyPmk7w2A84lWRMvteeY+zJan75O9xwgRC7FX gEMJExnAEBHY9tEW8dgB3EK07MFFQWLlVpGQll6BbLHxOcMIz17Pj/sI6+7Sv0xW cahUhiwZ1m+Y0EElAHIwQFoWyyyg7KINbFYsCsnyL1ev/EbUFyGCMRuR270OEIJW bKMoVE2keTYc8IQjmKqk7x/VPRLsTw== =LX/u -----END PGP SIGNATURE-----